'for' loop hygiene, etc. #15184
Merged
'for' loop hygiene, etc. #15184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fld.cx.expr_match(span, discrim, vec!(arm)) | ||
| // why these clone()'s everywhere? I guess I'll follow the pattern.... | ||
| let match_expr = fld.cx.expr_match(span, discrim, vec!(arm)); | ||
| fld.fold_expr(match_expr).clone() |
There was a problem hiding this comment.
Does this compile without the .clone?
There was a problem hiding this comment.
I'll give it a try. I worry that there's some hidden mutability that makes the clone() necessary and that the tests won't catch. Perhaps I should just have faith in the type system. If this one can go, I think there are a lot of other places where it could go, as well....
There was a problem hiding this comment.
Oh, since it's widespread sounds like that could be a separate patch to avoid blocking this one.
There was a problem hiding this comment.
Okay, I'm going to leave it alone for now.
|
r=me if clone removed |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jun 26, 2014
…ents It turns out that bindings introduced by 'for' loops were not treated hygienically. The fix for this is to make the 'for' expansion more like a macro; rather than expanding sub-pieces and then assembling them, we need to rewrite the for and then call expand again on the whole thing. This PR includes a test and the fix. It also contains a number of other things: - unit tests for other forms of hygiene (currently ignored) - a fix for the isaac.rs macro that (it turned out) was relying on capturing - other miscellaneous cleanup and comments
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
Disable mir interpreter for targets with different pointer size from host fix rust-lang#15182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that bindings introduced by 'for' loops were not treated hygienically. The fix for this is to make the 'for' expansion more like a macro; rather than expanding sub-pieces and then assembling them, we need to rewrite the for and then call expand again on the whole thing.
This PR includes a test and the fix.
It also contains a number of other things: